Deprecate Log Plugins (#94)

flyteorg · Jan 20, 2021 · 27f0eeb · 27f0eeb
1 parent 501b648
commit 27f0eeb
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 0 deletions.
diff --git a/flyteidl/clients/go/coreutils/logs/cloudwatch.go b/flyteidl/clients/go/coreutils/logs/cloudwatch.go
@@ -36,6 +36,7 @@ func (s cloudwatchLogPlugin) GetTaskLog(podName, namespace, containerName, conta
 	}, nil
 }
 
+// Deprecated: Please use NewTemplateLogPlugin from github.com/lyft/flyteplugins/go/tasks/pluginmachinery/tasklog instead.
 func NewCloudwatchLogPlugin(region, groupName string) LogPlugin {
 	return &cloudwatchLogPlugin{
 		region:    region,

diff --git a/flyteidl/clients/go/coreutils/logs/kubernetes.go b/flyteidl/clients/go/coreutils/logs/kubernetes.go
@@ -18,6 +18,7 @@ func (s kubernetesLogPlugin) GetTaskLog(podName, namespace, containerName, conta
 	}, nil
 }
 
+// Deprecated: Please use NewTemplateLogPlugin from github.com/lyft/flyteplugins/go/tasks/pluginmachinery/tasklog instead.
 func NewKubernetesLogPlugin(k8sURL string) LogPlugin {
 	return &kubernetesLogPlugin{
 		k8sURL: k8sURL,

diff --git a/flyteidl/clients/go/coreutils/logs/logs.go b/flyteidl/clients/go/coreutils/logs/logs.go
@@ -6,6 +6,7 @@ import (
 	"github.com/lyft/flyteidl/gen/pb-go/flyteidl/core"
 )
 
+// Deprecated: Please use Plugin interface from github.com/lyft/flyteplugins/go/tasks/pluginmachinery/tasklog instead.
 type LogPlugin interface {
 	// Generates a TaskLog object given necessary computation information
 	GetTaskLog(podName, namespace, containerName, containerID, logName string) (core.TaskLog, error)

diff --git a/flyteidl/clients/go/coreutils/logs/stackdriver.go b/flyteidl/clients/go/coreutils/logs/stackdriver.go
@@ -31,6 +31,7 @@ func (s *stackdriverLogPlugin) GetTaskLog(podName, namespace, containerName, con
 	}, nil
 }
 
+// Deprecated: Please use NewTemplateLogPlugin from github.com/lyft/flyteplugins/go/tasks/pluginmachinery/tasklog instead.
 func NewStackdriverLogPlugin(gcpProject, logResource string) LogPlugin {
 	return &stackdriverLogPlugin{
 		gcpProject:  gcpProject,