Skip to content

Commit

Permalink
Control contents of plugins.yaml (#198)
Browse files Browse the repository at this point in the history
  • Loading branch information
mbarrien authored Apr 11, 2024
1 parent 7ff0059 commit 090bd75
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 0 deletions.
2 changes: 2 additions & 0 deletions charts/flyte-core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ helm install gateway bitnami/contour -n flyte
| configmap.enabled_plugins.tasks.task-plugins.enabled-plugins | list | `["container","sidecar","k8s-array"]` | [Enabled Plugins](https://pkg.go.dev/github.com/lyft/flyteplugins/go/tasks/config#Config). Enable sagemaker*, athena if you install the backend plugins |
| configmap.k8s | object | `{"plugins":{"k8s":{"default-cpus":"100m","default-env-vars":[],"default-memory":"100Mi"}}}` | Kubernetes specific Flyte configuration |
| configmap.k8s.plugins.k8s | object | `{"default-cpus":"100m","default-env-vars":[],"default-memory":"100Mi"}` | Configuration section for all K8s specific plugins [Configuration structure](https://pkg.go.dev/github.com/lyft/flyteplugins/go/tasks/pluginmachinery/flytek8s/config) |
| configmap.plugins | object | `{}` | General plugins config. You should prefer other config files if possible. |
| configmap.plugins_yaml_enabled | bool | `false` | Control the contents of plugins.yaml if true |
| configmap.remoteData.remoteData.region | string | `"us-east-1"` | |
| configmap.remoteData.remoteData.scheme | string | `"local"` | |
| configmap.remoteData.remoteData.signedUrls.durationMinutes | int | `3` | |
Expand Down
5 changes: 5 additions & 0 deletions charts/flyte-core/templates/propeller/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,8 @@ data:
agent_service.yaml: | {{ tpl (toYaml .) $ | nindent 4 }}
{{- end }}
{{- end }}
{{- if .Values.configmap.plugins_yaml_enabled }}
{{- /* Intentionally not using with .Values.configmap.plugins since
we want to be able to render empty plugins.yaml */}}
plugins.yaml: | {{ tpl (toYaml .Values.configmap.plugins) $ | nindent 4 }}
{{- end }}
6 changes: 6 additions & 0 deletions charts/flyte-core/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -836,6 +836,12 @@ configmap:
# -- One option is to enable cloudwatch logging for EKS, update the region and log group accordingly
cloudwatch-enabled: false

# Hack to force overwriting of plugins.yaml if true
# -- Control the contents of plugins.yaml if true
plugins_yaml_enabled: false
# -- General plugins config. You should prefer other config files if possible.
plugins: {}

# ----------------------------------------------------------------
# Optional Modules
# Flyte built extensions that enable various additional features in Flyte.
Expand Down

0 comments on commit 090bd75

Please sign in to comment.