Skip to content

Commit

Permalink
bypassing cache lookup when node is in predicatephase (#4524)
Browse files Browse the repository at this point in the history
Signed-off-by: Daniel Rammer <[email protected]>
  • Loading branch information
hamersaw authored Dec 6, 2023
1 parent 94d79f5 commit 040a05f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion flytepropeller/pkg/controller/nodes/executor.go
Original file line number Diff line number Diff line change
Expand Up @@ -941,7 +941,7 @@ func (c *nodeExecutor) handleNotYetStartedNode(ctx context.Context, dag executor
}

var cacheStatus *catalog.Status
if cacheHandler, ok := h.(interfaces.CacheableNodeHandler); ok {
if cacheHandler, ok := h.(interfaces.CacheableNodeHandler); p.GetPhase() != handler.EPhaseSkip && ok {
cacheable, _, err := cacheHandler.IsCacheable(ctx, nCtx)
if err != nil {
logger.Errorf(ctx, "failed to determine if node is cacheable with err '%s'", err.Error())
Expand Down

0 comments on commit 040a05f

Please sign in to comment.