This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Change subscope to be named Datacatalog #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanadian
changed the title
EngHabu
approved these changes
Sep 16, 2019
| @@ -68,7 +68,7 @@ func (s *DataCatalogService) AddTag(ctx context.Context, request *catalog.AddTag | |||
| func NewDataCatalogService() *DataCatalogService { | |||
| configProvider := runtime.NewConfigurationProvider() | |||
| dataCatalogConfig := configProvider.ApplicationConfiguration().GetDataCatalogConfig() | |||
| catalogScope := promutils.NewScope(dataCatalogConfig.MetricsScope).NewSubScope("service") | |||
| catalogScope := promutils.NewScope(dataCatalogConfig.MetricsScope).NewSubScope("datacatalog") | |||
There was a problem hiding this comment.
so it'll say flyte:datacatalog ? not datacatalog:something ?
There was a problem hiding this comment.
Yes, the first level can be flyte if that's what you set in the config.yaml.
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Change subscope to be named Datacatalog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the subscope of the metrics to be
datacataloginstead of genericservice. This is because the top levelmetricScopecan be namespaced anything. So we should allow clients to use ametricScopethat does not have to dictatedatacatalog.