Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add Observability through Metrics and debug Logging #3

Merged
merged 7 commits into from
Aug 29, 2019
Merged

Conversation

chanadian
Copy link
Contributor

@chanadian chanadian commented Aug 28, 2019

This PR boosts observability of the service with Prometheus integration and more logging. On service start a prometheus service will be stood up that emits metrics from the service.

  • Start prometheus http service at endpoint from config
  • Added labeled metrics for timers, success/failure counts
  • Added special error casing for NotFound and AlreadyExists errors
  • Added more logging for error and debug

@chanadian chanadian requested review from katrogan and EngHabu August 28, 2019 21:11
pkg/errors/errors.go Outdated Show resolved Hide resolved
katrogan
katrogan previously approved these changes Aug 29, 2019
@chanadian chanadian changed the title Add Metrics and Logging Add Observability through Metrics and debug Logging Aug 29, 2019
@chanadian chanadian merged commit 0da0ffb into master Aug 29, 2019
@chanadian chanadian deleted the metrics branch August 29, 2019 18:11
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Add Observability through Metrics and debug Logging
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants