Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Infer GOOS and GOARCH from environment #103

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Infer GOOS and GOARCH from environment #103

merged 1 commit into from
Apr 12, 2023

Conversation

jeevb
Copy link
Contributor

@jeevb jeevb commented Apr 11, 2023

No description provided.

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #103 (b5f489e) into master (25c0a10) will increase coverage by 1.16%.
The diff coverage is n/a.

❗ Current head b5f489e differs from pull request most recent head fcad422. Consider uploading reports for the commit fcad422 to get more accurate results

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   68.50%   69.67%   +1.16%     
==========================================
  Files          31       31              
  Lines        1667     1385     -282     
==========================================
- Hits         1142      965     -177     
+ Misses        447      342     -105     
  Partials       78       78              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jeevb
Copy link
Contributor Author

jeevb commented Apr 12, 2023

On cr.flyte.org/flyteorg/datacatalog:v1.0.44:

/ # uname -a
Linux c515c950cc4a 5.15.49-linuxkit #1 SMP PREEMPT Tue Sep 13 07:51:32 UTC 2022 aarch64 Linux
/ # file $(which datacatalog)
/bin/datacatalog: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=kPVP2bI6lhkObnThpl-t/aufvVv5PfUNUCoA8UScg/_wLIwVTI2EO3sXJO2Sup/i0CXH2D5MhcYWR-lrQEw, not stripped

On this PR:

/ # uname -a
Linux 7f5a1c3ba94b 5.15.49-linuxkit #1 SMP PREEMPT Tue Sep 13 07:51:32 UTC 2022 aarch64 Linux
/ # file $(which datacatalog)
/bin/datacatalog: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=qBUaP2CkjjAm9-sIdmB5/vMSWPSQSq7Y0d31qVvSb/MQuZz4nzHLA0sYUX8ZO3/OgN5GI4miYbl79cUpacm, not stripped

@jeevb jeevb marked this pull request as ready for review April 12, 2023 04:22
@jeevb jeevb requested a review from kumare3 as a code owner April 12, 2023 04:22
@jeevb jeevb merged commit 9ebdb93 into master Apr 12, 2023
@jeevb jeevb deleted the jeev/multiarch branch April 12, 2023 04:22
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants