This repository has been archived by the owner on Jun 17, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go imports are formatted inconsistently throughout the flyteorg codebase. In particular,
goimports
orders imports within a block and optionally breaks them into standard, default, and third party packages, but it does not reformat already broken import blocks. There is a long discussion about this behavior here. As an alternativegci
will ensure that go imports are grouped into exactly the sections requested.This change
make goimports
to rungci
to format goimports into three sections: standard, default, and flyteorggci
as a linter forgolangci-lint
, which is run usingmake run
For an example of the formatted output of
make goimports
, see this dry run for flytepluginsFor instance, before:
After: