-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Airflow Plugin #1
Conversation
Signed-off-by: Samhita Alla <[email protected]>
Signed-off-by: Samhita Alla <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I did not review it closely. Will do in sometime
`launchplan_name` to trigger a workflow, or `task_name` to trigger a task; you can give a | ||
handful of other values that are optional, such as `project`, `domain`, `max_parallelism`, | ||
`raw_data_prefix`, `assumable_iam_role`, `kubernetes_service_account`, `labels`, `annotations`, | ||
`secrets`, `notifications`, `disable_notifications`, `oauth2_client`, `version`, and `inputs`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also now supported interruptible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interruptibe
needs to be given in the task metadata, right? I don't think we can send interruptible
when executing the task through FlyteRemote.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome +1
couple small comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is awesome.
It seems like we need to add a couple of Github Action workflows to run the tests.
I can help after merging this PR.
Signed-off-by: Samhita Alla <[email protected]>
Signed-off-by: Samhita Alla <[email protected]>
Signed-off-by: Samhita Alla <[email protected]>
Signed-off-by: Samhita Alla <[email protected]>
@pingsutw, I've added the GitHub workflows. Let me know if they work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Signed-off-by: Samhita Alla [email protected]