Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run the test suite as part of the nix build #477

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

PhilTaken
Copy link
Member

@PhilTaken PhilTaken commented Oct 18, 2024

can be used for ci / local dev setups since e.g. git calls in the test suite are not properly isolated from the host system

@PhilTaken PhilTaken self-assigned this Oct 18, 2024
@PhilTaken PhilTaken requested a review from zagy as a code owner October 18, 2024 11:16
@PhilTaken PhilTaken requested a review from Ma27 October 18, 2024 11:17
@PhilTaken
Copy link
Member Author

ah this'll need an extra iteration since tox tries to install the deps and github ci is sandboxed properly

@PhilTaken PhilTaken marked this pull request as draft October 18, 2024 11:30
@elikoga
Copy link
Member

elikoga commented Oct 18, 2024

You could think about running the test suite by yourself without using tox to invoke multiple python versions maybe?

@PhilTaken
Copy link
Member Author

PhilTaken commented Oct 22, 2024

You could think about running the test suite by yourself without using tox to invoke multiple python versions maybe?

theres is a pytestcheckhook provided by nixpkgs, unfortunately there appears to be a priority clash in PYTHONPATH between a vendored py.py in pytest and pylib where the former is imported first in the test suite

I'll look into how the priority is being handled here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants