fix: excludes "ambitiouspilots-toolbar-pushback" from the Incompatible Add-ons #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed "ambitiouspilots-toolbar-pushback" from the Incompatible Add-ons list.
tracernz
approved these changes
Oct 30, 2024
|
How confident are we this addon does not cause issues anymore? It seems to work most of the time, but I don’t think it’s perfect. Someone just today resolved an issue they had by not using the tool on the Discord; https://discord.com/channels/738864299392630914/785976111875751956/1301091398430232617 There is always a chance of coincidence but I suppose It depends what threshold of issues vs flights without issue there is - but we won’t know the latter. |
|
It’s certainly not in the same class as other addons that outright override our files. If we apply a consistent criteria then I think things like GSX would have to be added alongside this one. |
…-from-incompatible-add-ons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed "ambitiouspilots-toolbar-pushback" from the Incompatible Add-ons list.
The "ambitiouspilots-toolbar-pushback" add-on will no longer trigger the "Incompatible Add-ons!" pop-up in the installer when updating the A32NX.Fixes #[issue_no]
Summary of Changes
Removed "ambitiouspilots-toolbar-pushback" from the Incompatible Add-ons list.Screenshots (if necessary)
Additional context
The toolbar pushback add-on still triggered the "Incompatible Add-ons!" pop-up in the installer when updating the A32NX, even though the issues caused by this add-on have been fixed a long time ago (according to some of the developers).Discord username (if different from GitHub): batata7elwe