Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a380x): Fix green dot speed for heavy weights and high altitudes; Fix FMS speed target for GD > CLB speed limit #9522

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix(a380x): Fix green dot speed for heavy weights and high altitudes; Fix FMS speed target for GD > CLB speed limit #9522

wants to merge 2 commits into from
+22 −21

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Nov 15, 2024 •
edited
Loading

Fixes #9183

Summary of Changes

  • Fix extrapolation for green dot speed in PseudoFAC. Values which are not present in FCOM table are set to 260 (M0.853 at FL400)
  • Fix FMS short term managed speed when green dot is above climb speed limit

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Climb high with heavy aircraft, green dot shouldn't exceed VMO/MMO when staying within allowed weights and REC MAX FL.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@flogross89 flogross89 marked this pull request as ready for review November 15, 2024 04:16
@flogross89 flogross89 added the A380X Related to the A380X aircraft label Nov 15, 2024
@flogross89 flogross89 marked this pull request as draft November 15, 2024 04:19
2hwk
2hwk previously approved these changes Nov 15, 2024
View reviewed changes
@2hwk 2hwk requested a review from aguther November 15, 2024 08:57
@2hwk 2hwk dismissed their stale review November 15, 2024 08:57

not ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2hwk 2hwk 2hwk left review comments

@aguther aguther Awaiting requested review from aguther

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A380X Related to the A380X aircraft
Projects
Quality Assurance
Status: 🟡 Code Review: Ready for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[A380X] Improve green dot LUT in PRIM FE
2 participants
@flogross89 @2hwk