-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
54-Skip deployment when deployment artifacts filter result is empty #64
Conversation
… available to deploy
@azlam-abdulsalam does it require decision record? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 46.28% 46.36% +0.07%
==========================================
Files 73 73
Lines 2830 2836 +6
Branches 324 328 +4
==========================================
+ Hits 1310 1315 +5
- Misses 1495 1496 +1
Partials 25 25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
artifacts filter result is empty (#64) * chore: skip deployment when artifact filters didnt match any artifact available to deploy * chore: remove unecessary imports
…imized deployment (#67) * chore: fix typo in profile_retrieve.json (#63) * 54-Skip deployment when deployment artifacts filter result is empty (#64) * chore: skip deployment when artifact filters didnt match any artifact available to deploy * chore: remove unecessary imports * Update CreateSourcePackageImpl.ts chrore(typo): CreateSourcePackageImpl duplicate space in hint for optimized deployment --------- Co-authored-by: Tim Paulaskas <[email protected]> Co-authored-by: Diéffrei Quadros <[email protected]> Co-authored-by: Azlam <[email protected]>
Checklist
All items have to be completed before a PR is merged