Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

54-Skip deployment when deployment artifacts filter result is empty #64

Merged
merged 2 commits into from
May 27, 2024

Conversation

dieffrei
Copy link
Collaborator

@dieffrei dieffrei commented May 26, 2024

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at flxbl-sfp Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@dieffrei
Copy link
Collaborator Author

@azlam-abdulsalam does it require decision record?

Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.36%. Comparing base (5aca75a) to head (c4873ce).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   46.28%   46.36%   +0.07%     
==========================================
  Files          73       73              
  Lines        2830     2836       +6     
  Branches      324      328       +4     
==========================================
+ Hits         1310     1315       +5     
- Misses       1495     1496       +1     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dieffrei dieffrei changed the title 54 - Skip deployment when deployment artifacts filter result is empty 54-Skip deployment when deployment artifacts filter result is empty May 26, 2024
@azlam-abdulsalam azlam-abdulsalam self-requested a review May 27, 2024 01:01
Copy link

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dieffrei dieffrei merged commit 90c6165 into main May 27, 2024
7 of 8 checks passed
Goobles added a commit to Goobles/sfp-fork that referenced this pull request May 27, 2024
azlam-abdulsalam pushed a commit that referenced this pull request Jun 5, 2024
 artifacts filter result is empty (#64)

* chore: skip deployment when artifact filters didnt match any artifact available to deploy

* chore: remove unecessary imports
azlam-abdulsalam added a commit that referenced this pull request Jun 11, 2024
…imized deployment (#67)

* chore: fix typo in profile_retrieve.json (#63)

* 54-Skip deployment when deployment artifacts filter result is empty (#64)

* chore: skip deployment when artifact filters didnt match any artifact available to deploy

* chore: remove unecessary imports

* Update CreateSourcePackageImpl.ts

chrore(typo): CreateSourcePackageImpl duplicate space in hint for optimized deployment

---------

Co-authored-by: Tim Paulaskas <[email protected]>
Co-authored-by: Diéffrei Quadros <[email protected]>
Co-authored-by: Azlam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deploy should return success when filtering artifact result in empty list
2 participants