Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dependency:install): add release def filter v2 #108

Merged
merged 14 commits into from
Aug 6, 2024

Conversation

dieffrei
Copy link
Collaborator

@dieffrei dieffrei commented Aug 2, 2024

This allows for dependency install to be filtered by a release configuration, in that sense dependency install wil install external dependencies for packages that are filtered by the domain configuration

Originally created by alanjaouen

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at flxbl-sfp Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

alanjaouen and others added 7 commits July 22, 2024 20:31
* fix(fht): fht/ft not being applied for post deployment

* chore: remove unecessary workingDirectory attribute on fht yml file path

* Revert "chore: remove unecessary workingDirectory attribute on fht yml file path"

This reverts commit a82cd0a.

* chore: set default value for working directory
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.72%. Comparing base (2bd58ec) to head (7d95557).
Report is 51 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   46.36%   45.72%   -0.65%     
==========================================
  Files          73       72       -1     
  Lines        2836     3300     +464     
  Branches      328      713     +385     
==========================================
+ Hits         1315     1509     +194     
- Misses       1496     1654     +158     
- Partials       25      137     +112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@azlam-abdulsalam azlam-abdulsalam merged commit 644f700 into main Aug 6, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants