forked from dxatscale/sfpowerscripts
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dependency:install): add release def filter v2 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(fht): fht/ft not being applied for post deployment * chore: remove unecessary workingDirectory attribute on fht yml file path * Revert "chore: remove unecessary workingDirectory attribute on fht yml file path" This reverts commit a82cd0a. * chore: set default value for working directory
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
==========================================
- Coverage 46.36% 45.72% -0.65%
==========================================
Files 73 72 -1
Lines 2836 3300 +464
Branches 328 713 +385
==========================================
+ Hits 1315 1509 +194
- Misses 1496 1654 +158
- Partials 25 137 +112 ☔ View full report in Codecov by Sentry. |
5 tasks
azlam-abdulsalam
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for dependency install to be filtered by a release configuration, in that sense dependency install wil install external dependencies for packages that are filtered by the domain configuration
Originally created by alanjaouen
Checklist
All items have to be completed before a PR is merged