fix(picklist): Cannot read properties of undefined (reading 'Metadata')

* issues/1441 : Bug fix for picklist Deployment fixes the Cannot read properties of undefined (reading 'Metadata') included some trace logging for troubleshooting * fix: remove comment --------- Co-authored-by: Azlam <[email protected]>
flxbl-io · Nov 24, 2023 · 65e36ee · 65e36ee
1 parent 300fde5
commit 65e36ee
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/packages/core/src/package/deploymentCustomizers/PicklistEnabler.ts b/packages/core/src/package/deploymentCustomizers/PicklistEnabler.ts
@@ -74,8 +74,15 @@ export default class PicklistEnabler implements DeploymentCustomizer {
 
                     let picklistInOrg = await this.getPicklistInOrg(urlId, sfpOrg.getConnection());
 
-                    //check for empty picklists on org and fix first deployment issue
-                    if (!picklistInOrg && picklistInOrg?.Metadata?.valueSet?.valueSetDefinition) continue;
+                    if (!picklistInOrg?.Metadata?.valueSet?.valueSetDefinition)
+                        SFPLogger.log(
+                            `Picklist field ${objName}.${picklistName} not in target Org. Skipping`,
+                            LoggerLevel.TRACE,
+                            logger
+                        );
+                        continue;
+                    }
+
 
                     let picklistValueInOrg = [];
 
@@ -115,6 +122,7 @@ export default class PicklistEnabler implements DeploymentCustomizer {
             }
         } catch (error) {
             SFPLogger.log(`Unable to process Picklist update due to ${error.message}`, LoggerLevel.WARN, logger);
+            SFPLogger.log(`Error Details : ${error.stack}`, LoggerLevel.TRACE);
         }
     }