Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logger #370

Merged
merged 1 commit into from
Sep 8, 2022
Merged

fix logger #370

merged 1 commit into from
Sep 8, 2022

Conversation

harjotgill
Copy link
Contributor

@harjotgill harjotgill commented Sep 8, 2022

This change is Reviewable

@harjotgill harjotgill requested review from a team as code owners September 8, 2022 03:43
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Base: 48.81% // Head: 48.81% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (2101086) compared to base (dc22124).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #370   +/-   ##
=======================================
  Coverage   48.81%   48.81%           
=======================================
  Files         246      246           
  Lines       19164    19161    -3     
=======================================
- Hits         9354     9353    -1     
+ Misses       9192     9191    -1     
+ Partials      618      617    -1     
Impacted Files Coverage Δ
pkg/config/zz_generated.deepcopy.go 8.69% <ø> (-3.81%) ⬇️
pkg/config/log.go 58.33% <50.00%> (-0.97%) ⬇️
...taplane/resources/classifier/extractors/compile.go 77.56% <0.00%> (-0.65%) ⬇️
pkg/jobs/job.go 86.99% <0.00%> (+2.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@harjotgill harjotgill enabled auto-merge (squash) September 8, 2022 04:27
@harjotgill harjotgill changed the title refactor various components fix logger Sep 8, 2022
@harjotgill harjotgill merged commit dd77ac5 into main Sep 8, 2022
@harjotgill harjotgill deleted the refactor branch September 8, 2022 04:27
harjotgill added a commit that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants