Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor various components #366

Merged
merged 12 commits into from
Sep 8, 2022
Merged

Refactor various components #366

merged 12 commits into from
Sep 8, 2022

Conversation

harjotgill
Copy link
Contributor

@harjotgill harjotgill commented Sep 7, 2022

This change is Reviewable

@harjotgill harjotgill requested a review from a team as a code owner September 7, 2022 22:01
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Base: 48.82% // Head: 48.76% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (269b140) compared to base (bce5140).
Patch coverage: 9.61% of modified lines in pull request are covered.

❗ Current head 269b140 differs from pull request most recent head 9d16d67. Consider uploading reports for the commit 9d16d67 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
- Coverage   48.82%   48.76%   -0.07%     
==========================================
  Files         246      246              
  Lines       19176    19170       -6     
==========================================
- Hits         9363     9348      -15     
- Misses       9195     9203       +8     
- Partials      618      619       +1     
Impacted Files Coverage Δ
...nents/actuators/concurrency/concurrency-limiter.go 34.54% <0.00%> (ø)
...onents/actuators/concurrency/load-shed-actuator.go 21.21% <0.00%> (ø)
...lane/components/actuators/concurrency/scheduler.go 39.77% <0.00%> (ø)
...rolplane/components/actuators/rate/rate-limiter.go 0.00% <0.00%> (ø)
pkg/policies/controlplane/policy-factory.go 0.00% <0.00%> (ø)
...ies/controlplane/resources/fluxmeter/flux-meter.go 40.00% <0.00%> (ø)
...ies/dataplane/actuators/concurrency/auto-tokens.go 0.00% <0.00%> (ø)
...plane/actuators/concurrency/concurrency-limiter.go 0.00% <0.00%> (ø)
...aplane/actuators/concurrency/load-shed-actuator.go 0.00% <0.00%> (ø)
.../policies/dataplane/actuators/rate/rate-limiter.go 0.00% <0.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@harjotgill harjotgill changed the title refactor RunLimiter Refactor various components Sep 8, 2022
@harjotgill harjotgill requested a review from a team as a code owner September 8, 2022 02:02
@harjotgill harjotgill enabled auto-merge (squash) September 8, 2022 03:06
@harjotgill harjotgill merged commit dc22124 into main Sep 8, 2022
@harjotgill harjotgill deleted the refactor_runlimiter branch September 8, 2022 03:12
harjotgill added a commit that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants