Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixe ratelimiter decision sync #349

Merged
merged 6 commits into from
Sep 7, 2022
Merged

Fixe ratelimiter decision sync #349

merged 6 commits into from
Sep 7, 2022

Conversation

hasit
Copy link
Contributor

@hasit hasit commented Sep 6, 2022

  • Send correct message RateLimiterDecisionWrapper from controlplane component
  • Fix decision path on dataplane side

This change is Reviewable

- Send correct message `RateLimiterDecisionWrapper` from controlplane component
- Fix decision path on dataplane side
@hasit hasit requested a review from a team as a code owner September 6, 2022 21:25
@hasit hasit self-assigned this Sep 6, 2022
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Base: 48.75% // Head: 48.78% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (f388647) compared to base (c4514a2).
Patch coverage: 25.60% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
+ Coverage   48.75%   48.78%   +0.03%     
==========================================
  Files         246      246              
  Lines       19161    19167       +6     
==========================================
+ Hits         9342     9351       +9     
+ Misses       9202     9197       -5     
- Partials      617      619       +2     
Impacted Files Coverage Δ
...rolplane/components/actuators/rate/rate-limiter.go 0.00% <0.00%> (ø)
...plane/actuators/concurrency/concurrency-limiter.go 0.00% <0.00%> (ø)
.../policies/dataplane/actuators/rate/rate-limiter.go 0.00% <0.00%> (ø)
pkg/policies/dataplane/iface/limiter.go 100.00% <ø> (ø)
pkg/policies/mocks/mock_limiter.go 69.44% <0.00%> (+3.65%) ⬆️
pkg/policies/dataplane/engine.go 65.04% <30.43%> (-2.26%) ⬇️
pkg/config/koanf-unmarshaller.go 68.11% <68.42%> (-0.70%) ⬇️
pkg/flowcontrol/common/flowcontrol.go 100.00% <100.00%> (ø)
operator/controllers/agent_reconciler.go 48.81% <0.00%> (-0.48%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 7, 2022
@harjotgill harjotgill merged commit d42a2a2 into main Sep 7, 2022
@harjotgill harjotgill deleted the fix-ratelimit branch September 7, 2022 07:14
harjotgill added a commit that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants