Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground improvements #318

Merged
merged 4 commits into from
Sep 4, 2022
Merged

Playground improvements #318

merged 4 commits into from
Sep 4, 2022

Conversation

harjotgill
Copy link
Contributor

@harjotgill harjotgill commented Sep 4, 2022

  • Add PROTOCOL field to access logs under the label http.flavor
  • Move tanka/environment/tilt/apps to tanka/apps
  • Provide ctlptl cluster instructions
  • Isolate controller and agent namespaces

This change is Reviewable

@harjotgill harjotgill marked this pull request as ready for review September 4, 2022 00:51
@harjotgill harjotgill requested review from a team as code owners September 4, 2022 00:51
@harjotgill harjotgill requested a review from a team as a code owner September 4, 2022 02:52
@codecov
Copy link

codecov bot commented Sep 4, 2022

Codecov Report

Base: 49.42% // Head: 49.42% // No change to project coverage 👍

Coverage data is based on head (3e9e030) compared to base (6114e59).
Patch has no changes to coverable lines.

❗ Current head 3e9e030 differs from pull request most recent head c470880. Consider uploading reports for the commit c470880 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   49.42%   49.42%           
=======================================
  Files         226      226           
  Lines       18594    18594           
=======================================
  Hits         9191     9191           
+ Misses       8812     8811    -1     
- Partials      591      592    +1     
Impacted Files Coverage Δ
pkg/jobs/job.go 84.55% <0.00%> (-2.44%) ⬇️
operator/controllers/agent_reconciler.go 48.30% <0.00%> (-0.49%) ⬇️
...taplane/resources/classifier/extractors/compile.go 78.20% <0.00%> (+0.64%) ⬆️
operator/controllers/controller_reconciler.go 47.52% <0.00%> (+1.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@harjotgill harjotgill enabled auto-merge (squash) September 4, 2022 03:08
@harjotgill harjotgill merged commit 46c61ba into main Sep 4, 2022
@harjotgill harjotgill deleted the envoy_labels branch September 4, 2022 03:10
harjotgill added a commit that referenced this pull request Sep 9, 2022
* Add proto label

* ctlptl instructions

* separate namespace for controller and agent in playground

* remove certs directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants