Fix order of job groups and otel tests

[hasit]

Description of change

Checklist

• Tested in playground or other setup
• Screenshot (Grafana) from playground added to PR for 15+ minute run
• Documentation is changed or added
• Tests and/or benchmarks are included
• Breaking changes

Summary by CodeRabbit

• New Features

  • Enhanced telemetry capabilities for specific pipeline configurations.

• Bug Fixes

  • Improved shutdown sequence for quota scheduler and rate limiter components to ensure proper operation order.

[coderabbitai]

Walkthrough

The changes involve conditional logic and order of operations adjustments in a Go codebase. Specifically, a conditional check was added to modify a configuration for a metrics pipeline, and the shutdown sequences for job groups in quota-scheduler and rate-limiter components were reordered, which could affect how resources are released or synchronized.

Changes

File Path	Change Summary
.../otel/otel_test.go	Added a conditional check to append "attributes/agent_group" for a specific pipelineName.
.../flowcontrol/.../quota-scheduler.go .../flowcontrol/.../rate-limiter.go	Swapped the order of Stop calls for different job groups in shutdown procedures.

🐇✨
In the realm of code, where logic threads weave,
A rabbit hopped through, changes to conceive.
With a flip and a swap, the order's made neat,
Now the code hops along, with nary a beat. 🌟
🐰💻

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 8bf3b05 and 979218f.

Files ignored due to path filters (1)

• api/buf.lock is excluded by: !**/*.lock

Files selected for processing (3)

• extensions/fluxninja/otel/otel_test.go (1 hunks)
• pkg/policies/flowcontrol/actuators/quota-scheduler/quota-scheduler.go (1 hunks)
• pkg/policies/flowcontrol/actuators/rate-limiter/rate-limiter.go (1 hunks)

Additional comments: 3

extensions/fluxninja/otel/otel_test.go (1)

• 144-146: The conditional logic added to the withMetrics method is clear and correctly appends "attributes/agent_group" to the processors slice when pipelineName is "metrics/slow". Ensure that the "attributes/agent_group" processor is defined elsewhere and that its addition here is consistent with the intended behavior.

pkg/policies/flowcontrol/actuators/rate-limiter/rate-limiter.go (1)

• 173-177: Swapping the stopping order of lazySyncJobGroup and rateLimiterJobGroup could have implications on the shutdown sequence. Verify that this new order does not introduce any race conditions or deadlocks, especially if these job groups are interdependent or share resources.

pkg/policies/flowcontrol/actuators/quota-scheduler/quota-scheduler.go (1)

• 161-165: The change in stopping order of auditJobGroup and rateLimiterJobGroup should be carefully evaluated to ensure it does not introduce any issues during the shutdown process. Confirm that dependencies between these job groups are properly managed and that this new order maintains a clean and safe shutdown sequence.