Keep reference to the storage client so that we can close it during Stop()

[kklimonda-fn]

Description of change

Checklist

• Tested in playground or other setup
• Screenshot (Grafana) from playground added to PR for 15+ minute run
• Documentation is changed or added
• Tests and/or benchmarks are included
• Breaking changes

Summary by CodeRabbit

• Refactor
  • Improved the initialization process for object storage handling.

[coderabbitai]

Important

Auto Review Skipped

Review was skipped due to path filters

Walkthrough

The recent update involves a modification in the initialization process of ObjectStorage. The change is focused on ensuring that the client and bucket fields are set prior to the launch of a background process. This adjustment could potentially enhance stability and consistency in the object storage service.

Changes

File	Summary
.../object-storage.go	Start method now initializes client and bucket before starting a goroutine.

Poem

🐇
In the code where bytes do flow,
A rabbit tweaked the storage glow.
Fields set before the threads do hop,
Ensuring data won't flop or drop. 🎉

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 6

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between bed5635 and 7caa1af.

Files selected for processing (1)

• pkg/objectstorage/object-storage.go (1 hunks)

Additional comments: 2

pkg/objectstorage/object-storage.go (2)

• 381-383: The assignment of client and bucket to the ObjectStorage struct fields within the Start method is a critical change. This ensures that the client can be closed during the Stop method execution, which is a good practice for resource management.

• 383-383: The Stop method correctly acquires a lock and defers its release, ensuring that all in-flight operations are completed before closing the client. This is a good practice for clean resource shutdown.