Fix wait time based deadline calculation

[tanveergill]

Description of change

Checklist

• Tested in playground or other setup
• Screenshot (Grafana) from playground added to PR for 15+ minute run
• Documentation is changed or added
• Tests and/or benchmarks are included
• Breaking changes

Summary by CodeRabbit

• Refactor
  • Improved the concurrency limiter by adjusting the wait time to be within specified minimum and maximum limits, enhancing the control flow and logic for better performance and user experience.

[coderabbitai]

Walkthrough

The recent update to the system introduces a refined token acquisition strategy in the concurrency limiter. The takeN function now adheres to predefined minimum and maximum wait time thresholds, enhancing the method's decision-making process for managing wait times within these bounds.

Changes

File Path	Summary of Changes
.../concurrency-limiter/global-token-counter.go	Adjusted the takeN method in GlobalTokenCounter to enforce waitTime between MinimumWaitTime and MaximumWaitTime.

🐇✨
To manage the flow, we hop and we wait,
In the code, we now have a min-max debate.
Ensuring our tokens are fairly spent,
With bounds in place, we prevent time's dent. 🕒🔒

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• You can directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
  • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 4fefe0b and f60fa9e.

Files selected for processing (1)

• pkg/dmap-funcs/concurrency-limiter/global-token-counter.go (2 hunks)

Additional comments: 1

pkg/dmap-funcs/concurrency-limiter/global-token-counter.go (1)

• 424-429: The checks to ensure waitTime is within the minimum and maximum bounds are correctly placed after all calculations of waitTime. This ensures that no matter how waitTime is calculated or modified, it will not exceed the specified range.