Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment why histogram might already exists in metricsprocessor #250

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

krdln
Copy link
Contributor

@krdln krdln commented Aug 30, 2022

cc @DariaKunoichi @kwapik


This change is Reviewable

@krdln krdln requested a review from a team as a code owner August 30, 2022 11:42
@krdln krdln enabled auto-merge (squash) August 30, 2022 11:42
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Base: 49.28% // Head: 49.24% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (0a52f82) compared to base (7ac6103).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
- Coverage   49.28%   49.24%   -0.05%     
==========================================
  Files         226      226              
  Lines       18850    18854       +4     
==========================================
- Hits         9291     9285       -6     
- Misses       8963     8971       +8     
- Partials      596      598       +2     
Impacted Files Coverage Δ
pkg/otelcollector/metricsprocessor/processor.go 71.02% <0.00%> (-1.36%) ⬇️
...ne/actuators/concurrency/scheduler/token-bucket.go 95.60% <0.00%> (-4.40%) ⬇️
...s/dataplane/actuators/concurrency/scheduler/wfq.go 98.65% <0.00%> (-1.35%) ⬇️
operator/controllers/agent_reconciler.go 48.30% <0.00%> (+0.48%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@krdln krdln merged commit 3369dac into main Aug 30, 2022
@krdln krdln deleted the why-histogram-already-exists branch August 30, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants