Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-couple FluxMeters from Policy, make them global #241

Merged
merged 5 commits into from
Aug 30, 2022

Conversation

tanveergill
Copy link
Contributor

@tanveergill tanveergill commented Aug 29, 2022

This change is Reviewable

@tanveergill tanveergill requested a review from a team as a code owner August 29, 2022 20:43
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Base: 49.36% // Head: 49.26% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (aa5651f) compared to base (c278e29).
Patch coverage: 75.93% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
- Coverage   49.36%   49.26%   -0.11%     
==========================================
  Files         226      226              
  Lines       18862    18850      -12     
==========================================
- Hits         9311     9286      -25     
- Misses       8949     8967      +18     
+ Partials      602      597       -5     
Impacted Files Coverage Δ
pkg/policies/controlplane/runtime/circuit.go 0.00% <ø> (ø)
pkg/policies/dataplane/iface/engine.go 0.00% <ø> (ø)
...licies/dataplane/resources/fluxmeter/flux-meter.go 0.00% <0.00%> (ø)
pkg/policies/mocks/mock_flux_meter.go 71.73% <ø> (+16.02%) ⬆️
pkg/policies/controlplane/policy.go 28.39% <41.66%> (-0.91%) ⬇️
pkg/policies/controlplane/component-factory.go 64.12% <72.72%> (+0.78%) ⬆️
...g/policies/controlplane/component-stack-factory.go 68.25% <86.36%> (+0.94%) ⬆️
pkg/policies/controlplane/circuit-factory.go 59.22% <89.47%> (-15.45%) ⬇️
pkg/otelcollector/metricsprocessor/processor.go 72.38% <100.00%> (-0.39%) ⬇️
pkg/paths/paths.go 100.00% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tanveergill tanveergill merged commit 81521e7 into main Aug 30, 2022
@tanveergill tanveergill deleted the tgill/global-flux-meter branch August 30, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant