Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics names to common schema #212

Merged
merged 1 commit into from
Aug 27, 2022
Merged

Add metrics names to common schema #212

merged 1 commit into from
Aug 27, 2022

Conversation

DariaKunoichi
Copy link
Contributor

@DariaKunoichi DariaKunoichi commented Aug 27, 2022

This change is Reviewable

@DariaKunoichi DariaKunoichi marked this pull request as ready for review August 27, 2022 18:48
@DariaKunoichi DariaKunoichi requested a review from a team as a code owner August 27, 2022 18:48
@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

Merging #212 (1d93a36) into main (f5fb8cb) will decrease coverage by 39.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #212       +/-   ##
==========================================
- Coverage   42.61%   3.41%   -39.20%     
==========================================
  Files         207     224       +17     
  Lines       15745   18627     +2882     
==========================================
- Hits         6710     637     -6073     
- Misses       8632   17920     +9288     
+ Partials      403      70      -333     
Impacted Files Coverage Δ
cmd/aperture-controller/controller/provider.go 0.00% <0.00%> (ø)
operator/controllers/agent_daemonset.go 0.00% <ø> (ø)
operator/controllers/agent_pod.go 0.00% <ø> (ø)
operator/controllers/aperture_controller.go 0.00% <ø> (ø)
operator/controllers/clusterrole.go 0.00% <ø> (ø)
operator/controllers/configmaps.go 0.00% <ø> (ø)
operator/controllers/controller_deployment.go 0.00% <ø> (ø)
...ator/controllers/mutating_webhook_configuration.go 0.00% <ø> (ø)
operator/controllers/mutating_webhook_handler.go 0.00% <ø> (ø)
operator/controllers/namespace_controller.go 0.00% <ø> (ø)
... and 186 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@DariaKunoichi DariaKunoichi merged commit 0b87dd1 into main Aug 27, 2022
@DariaKunoichi DariaKunoichi deleted the metric_names branch August 27, 2022 20:07
harjotgill pushed a commit that referenced this pull request Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants