Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand doc comments for policies #160

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Expand doc comments for policies #160

merged 1 commit into from
Aug 25, 2022

Conversation

krdln
Copy link
Contributor

@krdln krdln commented Aug 23, 2022

Resolves: #143


This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #160 (008764f) into main (f5fb8cb) will increase coverage by 3.89%.
The diff coverage is 85.71%.

❗ Current head 008764f differs from pull request most recent head 3b599a3. Consider uploading reports for the commit 3b599a3 to get more accurate results

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   42.61%   46.50%   +3.89%     
==========================================
  Files         207      224      +17     
  Lines       15745    18534    +2789     
==========================================
+ Hits         6710     8620    +1910     
- Misses       8632     9376     +744     
- Partials      403      538     +135     
Impacted Files Coverage Δ
operator/controllers/agent_daemonset.go 94.23% <ø> (ø)
operator/controllers/agent_pod.go 100.00% <ø> (ø)
operator/controllers/aperture_controller.go 45.82% <ø> (ø)
operator/controllers/clusterrole.go 91.74% <ø> (ø)
operator/controllers/configmaps.go 71.32% <ø> (ø)
operator/controllers/controller_deployment.go 94.59% <ø> (ø)
...ator/controllers/mutating_webhook_configuration.go 95.31% <ø> (ø)
operator/controllers/mutating_webhook_handler.go 0.00% <ø> (ø)
operator/controllers/namespace_controller.go 64.86% <ø> (ø)
operator/controllers/secrets.go 67.27% <ø> (ø)
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@CLAassistant
Copy link

CLAassistant commented Aug 25, 2022

CLA assistant check
All committers have signed the CLA.

@krdln krdln force-pushed the policy-proto-docs branch from f5576af to 008764f Compare August 25, 2022 14:15
@krdln krdln marked this pull request as ready for review August 25, 2022 15:31
@krdln krdln requested a review from a team as a code owner August 25, 2022 15:31
Non-actuator components for now.
@krdln krdln force-pushed the policy-proto-docs branch from 008764f to 3b599a3 Compare August 25, 2022 23:54
@krdln krdln enabled auto-merge (squash) August 25, 2022 23:54
@krdln krdln merged commit dc64169 into main Aug 25, 2022
@krdln krdln deleted the policy-proto-docs branch August 25, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing comments to policy proto
3 participants