-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kubernetes client auth exec config support #506
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relu
force-pushed
the
kubernetes-exec
branch
2 times, most recently
from
June 30, 2023 13:17
f8dbc43
to
342522e
Compare
stefanprodan
added
the
area/kubernetes
Kubernetes bootstrap related issues and pull requests
label
Jun 30, 2023
darkowlzz
reviewed
Jul 3, 2023
darkowlzz
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Left a few minor suggestions that can be addressed or ignored.
Signed-off-by: Aurel Canciu <[email protected]>
The implementation is similar to other Kubernetes Terraform providers such as the kubectl or helm providers and allows the Flux provider to authenticate against EKS clusters (or others supporting this method) by configuring the client authentication exec plugin. Example configuration for EKS: ``` provider "flux" { ... kubernetes = { ... exec = { api_version = "client.authentication.k8s.io/v1beta1" env = { AWS_PROFILE = "example-profile" } command = "aws" args = [ "--region", "us-east-1", "eks", "get-token", "--cluster-name", "example-cluster", ] } } } ``` Signed-off-by: Aurel Canciu <[email protected]>
12 tasks
stefanprodan
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @relu 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/kubernetes
Kubernetes bootstrap related issues and pull requests
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is similar to other Kubernetes Terraform providers
such as the kubectl or helm providers and allows the Flux provider to
authenticate against EKS clusters (or others supporting this method) by
configuring the client authentication exec plugin.
Example configuration for EKS:
Closes: #406