Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout configuration and retry functions #436

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Conversation

phillebaba
Copy link
Member

@phillebaba phillebaba commented Mar 29, 2023

This change allows users to configure a timeout for different operations. This is useful for those with slow image pull duration and other issues. Additionally this change introduces retry logic on functions that may have issues caused by race conditions with the Git repository, when another process pushes a commit in between the provider pulling and pushing.

Fixes #431

@phillebaba phillebaba force-pushed the feature/timeout branch 2 times, most recently from ac1c00a to 74ad832 Compare April 2, 2023 17:09
@phillebaba
Copy link
Member Author

The failing tests are caused by a bug in the import logic. I have created an issue in the timeout library to see if this is an issue with my code or the library.

hashicorp/terraform-plugin-framework-timeouts/issues/46

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiple clusters pushing to same repo can cause git collision
2 participants