gogit: Add new ForceGoGitImplementation FeatureGate #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbgf
commented
Oct 27, 2022
pjbgf
force-pushed
the
feature-nolibgit2
branch
from
48b5b85
to
5f02724
Compare
pjbgf
force-pushed
the
feature-nolibgit2
branch
4 times, most recently
from
9a9fa2c
to
d5872c2
Compare
hiddeco
reviewed
Nov 2, 2022
Comment on lines
431
to
428
| if enabled, _ := r.features[features.ForceGoGitImplementation]; enabled { | ||
| gitImplementation = sourcev1.GoGitImplementation | ||
| } |
There was a problem hiding this comment.
As this is done multiple times, I am wondering if it might be better to factor this out into a helper function which takes the object and string map and returns the correct implementation?
There was a problem hiding this comment.
@darkowlzz gave a similar feedback on this and suggested the output of the feature gate to be passed as parameter to gitCheckout, which aligns with the current implementation for optimized clones. PTAL
pjbgf
force-pushed
the
feature-nolibgit2
branch
from
d5872c2
to
3748d2d
Compare
darkowlzz
reviewed
Nov 3, 2022
pjbgf
force-pushed
the
feature-nolibgit2
branch
from
3748d2d
to
84f4fc4
Compare
darkowlzz
reviewed
Nov 4, 2022
22 tasks
pjbgf
force-pushed
the
feature-nolibgit2
branch
from
84f4fc4
to
1a9724b
Compare
darkowlzz
reviewed
Nov 9, 2022
Signed-off-by: Paulo Gomes <[email protected]>
pjbgf
force-pushed
the
feature-nolibgit2
branch
2 times, most recently
from
af226fa
to
4f323e9
Compare
added 2 commits
November 11, 2022 10:25
ForceGoGitImplementation ignores the value set for gitImplementation and ensures that go-git is used for all GitRepository objects. This can be used to confirm that Flux instances won't break if/when the libgit2 implementation was to be deprecated. When enabled, libgit2 won't be initialized, nor will any git2go cgo code be called. Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
pjbgf
force-pushed
the
feature-nolibgit2
branch
from
4f323e9
to
bdcf708
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ForceGoGitImplementationignores the value set forgitImplementationand ensures that go-git is used for allGitRepositoryobjects. When enabled, libgit2 won't be initialized, nor will any git2go cgo code be called.This is a soft-decommissioning of
libgit2, to confirm that Flux instances won't break when that implementation is deprecated.