Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle nil OCI authenticator with malformed registry #897

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Handle nil OCI authenticator with malformed registry #897

merged 1 commit into from
Sep 14, 2022

Conversation

adrien-f
Copy link
Contributor

Fixes #896

Signed-off-by: Adrien Fillon [email protected]

@adrien-f adrien-f mentioned this pull request Sep 13, 2022
Closed
@makkes
Copy link
Member

makkes commented Sep 13, 2022

Would it be possible to add a regression test?

@adrien-f
Copy link
Contributor Author

Sure thing, I've actually moved the change from controllers/ocirepository_controller.go to controllers/helmrepository_controller_oci.go as they're not expecting the same behavior if the authenticator is nil.

@makkes makkes added bug Something isn't working area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests labels Sep 14, 2022
@makkes makkes merged commit 9ab1522 into fluxcd:main Sep 14, 2022
@adrien-f adrien-f deleted the panic-oci-auth branch September 14, 2022 18:32
@bnsfrt bnsfrt mentioned this pull request Sep 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makkes makkes makkes approved these changes

Assignees

@adrien-f adrien-f

Labels
area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic with an invalid AWS OCI URL for HelmRepository
2 participants
@adrien-f @makkes