Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgit2: fix access to nil t.stdin and improve observability #649

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Mar 30, 2022

All errors that were previously not handled are now logged through traceLog, to further help during transport investigations.

Attempts to fix #402 (comment)

@pjbgf pjbgf added the area/git Git related issues and pull requests label Mar 30, 2022
@pjbgf pjbgf force-pushed the fix-libgit2-panic branch 2 times, most recently from 230ba20 to 2e7acec Compare March 30, 2022 13:32
@pjbgf pjbgf self-assigned this Mar 30, 2022
All errors that were previously not handled are now logged through
traceLog, to further help during transport investigations.

Signed-off-by: Paulo Gomes <[email protected]>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @pjbgf

@pjbgf pjbgf merged commit 0bdc22d into fluxcd:main Mar 30, 2022
@pjbgf pjbgf deleted the fix-libgit2-panic branch March 30, 2022 14:21
@pjbgf pjbgf added this to the GA milestone Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git Git related issues and pull requests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Azure DevOps: Source controller getting stuck
2 participants