Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OCI distribution to v3.0.0-alpha.1 #1346

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

stefanprodan
Copy link
Member

Update distribution (only used in tests) and adapt to breaking changes.

@stefanprodan stefanprodan added the dependencies Pull requests that update a dependency label Jan 26, 2024
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

logger := logrus.New()
logger.SetOutput(io.Discard)
dcontext.SetDefaultLogger(logrus.NewEntry(logger))
logrus.SetOutput(io.Discard)
Copy link
Contributor

@darkowlzz darkowlzz Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice now. Just tested and verified that they use the global logrus logger now and all the server logs continue to be suppressed.
We should update the same in pkg/oci test registry too, refer https://github.com/fluxcd/pkg/blob/7fabcd8e2bcc9e812c8ecf643113b0dce95468c9/oci/client/suite_test.go#L47 .

@stefanprodan stefanprodan added the backport:release/v1.2.x To be backported to release/v1.2.x label Jan 26, 2024
@stefanprodan stefanprodan merged commit 6264713 into main Jan 26, 2024
12 checks passed
@stefanprodan stefanprodan deleted the distribution-up branch January 26, 2024 14:03
@fluxcdbot
Copy link
Member

Successfully created backport PR for release/v1.2.x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:release/v1.2.x To be backported to release/v1.2.x dependencies Pull requests that update a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants