gitrepo: Add support for specifying proxy per GitRepository
#1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryan9600
added
enhancement
darkowlzz
reviewed
May 30, 2023
aryan9600
force-pushed
the
gitrepo-proxy
branch
5 times, most recently
from
6515aaf
to
c74f6b1
Compare
hiddeco
reviewed
Jun 30, 2023
darkowlzz
reviewed
Jun 30, 2023
darkowlzz
approved these changes
Jul 19, 2023
aryan9600
force-pushed
the
gitrepo-proxy
branch
2 times, most recently
from
e41a5ea
to
5143135
Compare
Add `.spec.proxySecretRef.name` to the `GitRepository` API to allow referencing a secret containing the proxy settings to be used for all remote Git operations for the particular `GitRepository` object. It takes precedence over any proxy configured through enviornment variables. Signed-off-by: Sanskar Jaiswal <[email protected]>
pjbgf
reviewed
Jul 26, 2023
| ``` | ||
|
|
||
| Proxying can also be configured in the source-controller Deployment directly by | ||
| using the standard environment variables such as `HTTPS_PROXY`, `ALL_PROXY`, etc. |
There was a problem hiding this comment.
There was a problem hiding this comment.
The cheatsheet is going away, we'll have a dedicated page for Proxy settings under installation/configuration, see fluxcd/website#1560. For now let's leave it like this, after the docs refactoring we can link to it from here.
stefanprodan
approved these changes
Jul 26, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
.spec.proxySecretRef.nameto theGitRepositoryAPI to allow referencing a secret containing the proxy settings to be used for all remote Git operations for the particularGitRepositoryobject. It takes precedence over any proxy configured through environment variables.This allows for users to specify different proxy settings for different
GitRepositoryobjects as opposed to the current way of using env vars to specify proxy settings at a global controller level. This is particularly useful when the controller is running in a multi-tenant environment and tenants want to use their own proxy servers.