Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use registry region to get token for AWS #600

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

somtochiama
Copy link
Member

@somtochiama somtochiama commented Jul 6, 2023

This pull request basically reverts a change introduced in #560 where the region of the instance was used instead of the region from the registry url

Ref: fluxcd/source-controller#1155

Signed-off-by: Somtochi Onyekwere <[email protected]>
@stefanprodan stefanprodan added bug Something isn't working area/oci OCI related issues and pull requests labels Jul 6, 2023
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now it LGTM!
We'll work on adding corss-region auth integration tests separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oci OCI related issues and pull requests bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants