Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git/gogit: add multi_ack/multi_ack_detailed as a supported capability #576

Merged
merged 1 commit into from
May 31, 2023

Conversation

aryan9600
Copy link
Member

@aryan9600 aryan9600 commented May 31, 2023

Remove multi_ack and multi_ack_detailed from transport.UnsupportedCapabilities as they're required to work Git v2 servers such as Azure Devops and AWS CodeCommit.

Related to fluxcd/flux2#3936

@aryan9600 aryan9600 requested a review from hiddeco as a code owner May 31, 2023 10:51
git/gogit/client.go Outdated Show resolved Hide resolved
@hiddeco hiddeco added bug Something isn't working area/git Git and SSH related issues and pull requests labels May 31, 2023
Remove `multi_ack` and `multi_ack_detailed` from
`transport.UnsupportedCapabilities` as they're required to work Git v2
servers such as Azure Devops.

Signed-off-by: Sanskar Jaiswal <[email protected]>
@somtochiama
Copy link
Member

I have tested that this fixes the issue on Azure DevOps. Cloning a git repository and image update automation works okay.
I tested with images:

source-controller: quay.io/aryan9600/source-controller:multi-ack-89f6ad1
image-automation-controller: quay.io/aryan9600/image-automation-controller:multi-ack-89f6ad1

@aryan9600 aryan9600 merged commit fe2cbaa into main May 31, 2023
@aryan9600 aryan9600 deleted the multi-ack branch May 31, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git Git and SSH related issues and pull requests bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants