Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git/gogit: set HostKeyCallback for parent PublicKeys object #571

Merged
merged 1 commit into from
May 25, 2023

Conversation

aryan9600
Copy link
Member

@aryan9600 aryan9600 commented May 25, 2023

Set HostKeyCallback for the parent PublicKeys object to avoid setting the callback to one that uses the system's known_hosts.

Fixes errors seen in: https://github.com/fluxcd/source-controller/actions/runs/5072863613/jobs/9111130473#step:4:164

@aryan9600 aryan9600 requested a review from hiddeco as a code owner May 25, 2023 08:22
@hiddeco hiddeco added bug Something isn't working area/git Git and SSH related issues and pull requests labels May 25, 2023
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While not blocking to get this quickly patched, I think we should add a test to ensure regression does not occur.

Set `HostKeyCallback` for the parent `PublicKeys` object to avoid
setting the callback to one that uses the system's known_hosts.

Signed-off-by: Sanskar Jaiswal <[email protected]>
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test 🥇

@aryan9600 aryan9600 merged commit c33a483 into main May 25, 2023
@aryan9600 aryan9600 deleted the hostkey-callback branch May 25, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git Git and SSH related issues and pull requests bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants