Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use registry host to get ACR access token and add new OIDCLogin function #560

Merged
merged 3 commits into from
May 25, 2023
Merged

Use registry host to get ACR access token and add new OIDCLogin function #560

merged 3 commits into from
May 25, 2023

Commits on May 25, 2023

  1. Use instance region for aws region instead of parsing region from ecr… 

    … registry url.

This commits removes the code that parses the region from the ecr registry and uses it to set the config.
By default, LoadDefaultConfig will get the region of the instance from the metadata service which is the
correct region that should be used when requesting for a token.

Signed-off-by: Somtochi Onyekwere <[email protected]>
    @somtochiama
    somtochiama committed May 25, 2023
    Configuration menu
    Copy the full SHA
    1af760d View commit details
    Browse the repository at this point in the history

  2. Implement new OIDC Login method and update old Login method to ignore… 

    … ref argument

The Login function in oci/auth no longer uses the name.Reference argument and instead
gets the registry host from the image argument and passes that to the Login method of
the different region. This is to allow login to consumers of this function that don't
have a repository name and just a registry host.

Signed-off-by: Somtochi Onyekwere <[email protected]>
    @somtochiama
    somtochiama committed May 25, 2023
    Configuration menu
    Copy the full SHA
    48ad0eb View commit details
    Browse the repository at this point in the history

  3. Update oci integration tests to test OIDCLogin 

    It also updates the Makefile to build the testapp for linux/amd64
by default. This can be changed by setting GOARCH and GOOS variables.

Signed-off-by: Somtochi Onyekwere <[email protected]>
    @somtochiama
    somtochiama committed May 25, 2023
    Configuration menu
    Copy the full SHA
    1c2956b View commit details
    Browse the repository at this point in the history