runtime/reconcile: Fix Ready check in Finalizer #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the Ready condition check in the ResultFinalizer. `IsReady()` takes into account the Reconciling and Stalling conditons too. Use `IsTrue()` to precisely check if Ready=True. This ensure that Ready=True is toggled when there's a reconciliation error in presence or other negative conditions. Signed-off-by: Sunny <[email protected]>
darkowlzz
added
the
area/runtime
hiddeco
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Ready condition check in the ResultFinalizer.
IsReady()takes into account the Reconciling and Stalling conditons too. UseIsTrue()to precisely check if Ready=True.This ensures that Ready=True is toggled when there's a reconciliation error in presence or other negative conditions.
This is needed to fix the issue in fluxcd/image-reflector-controller#356.