Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oci/auth: Fix ImageRegistryProvider for repo root #434

Merged
merged 1 commit into from
Dec 14, 2022
Merged

oci/auth: Fix ImageRegistryProvider for repo root #434

merged 1 commit into from
Dec 14, 2022

Commits on Dec 14, 2022

  1. oci/auth: Fix ImageRegistryProvider for repo root 

    When a repository root is provided, ImageRegistryProvider() fails to
identify the registry host. The provided name.Reference for repository
root is a Tag reference.
name.ParseReference(), assumes that that given string is the name and
registry host being empty defaults to index.docker.io.

ImageRegistryProvider() now takes the full address, in addition to the
name.Reference and uses the full address for analysis if there's no "/"
in the address, which indicates that it's a repository root.

This fixes login with repository root for all the providers, not just
AWS.

Signed-off-by: Sunny <[email protected]>
    @darkowlzz
    darkowlzz committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    cb4fdc7 View commit details
    Browse the repository at this point in the history