git: change Commit#String format #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
commit-string-fmt
branch
8 times, most recently
from
f8fd945 to
721d447
Compare
hiddeco
force-pushed
the
commit-string-fmt
branch
3 times, most recently
from
f62b6da to
0360540
Compare
hiddeco
added
area/git
pjbgf
approved these changes
Dec 14, 2022
hiddeco
force-pushed
the
commit-string-fmt
branch
from
0360540 to
17a6d74
Compare
|
Given we are also optimizing some other bits of the Git package at present to facilitate the removal of libgit2 and address other issues. I suggest we keep this on hold until I have my proposed changes incorporating RFC-0005 for source-controller ready. |
hiddeco
force-pushed
the
commit-string-fmt
branch
from
17a6d74 to
1ac5d56
Compare
21 tasks
hiddeco
force-pushed
the
commit-string-fmt
branch
from
1ac5d56 to
3217c53
Compare
This changes the string format of `Commit` to use an `@` separator instead of `/`, and drops the usage of "HEAD" as a virtual named reference for commits without a named pointer (e.g. a Git branch and/or tag). Matching the (revision) format proposed in RFC-0005. Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
This ensures the Git implementations transform any LastObservedCommit value into the new format before comparing it to what they constructed from the remote state. Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
commit-string-fmt
branch
from
3217c53 to
db0daab
Compare
10 tasks
hiddeco
added a commit
that referenced
this pull request
Feb 10, 2023
This ensures this strategy is backwards compatible as well, as I accidentally forgot to do this for go-git in #404. This lacks tests (as does the libgit2 implementation), and it would probably be good to make them less dynamic as a follow up, as that's how this slipped through the cracks. Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
added a commit
that referenced
this pull request
Feb 10, 2023
This ensures this strategy is backwards compatible as well, as I accidentally forgot to do this for go-git in #404. This lacks tests (as does the libgit2 implementation), and it would probably be good to make them less dynamic as a follow up, as that's how this slipped through the cracks. Signed-off-by: Hidde Beydals <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the string format of
Committo use an@separator instead of/, and drops the usage of "HEAD" as a virtual named reference for commits without a named pointer (e.g. a Git branch and/or tag). Matching the (revision) format proposed in RFC-0005.The
LastObservedCommitoption is made backwards compatible, allowing consumers to provide a revision string in the previous format without issues.To help consumers address possible compatibility issues while working with the new (returned) format, the following functions have been added:
TransformRevision: allows for transforming a "legacy revision" (i.e.feature/branch/5394cb7f48332b2de7c17dd8b8384bbc84b7e738orHEAD/5394cb7f48332b2de7c17dd8b8384bbc84b7e738) into a RFC-0005 compatible revision (i.e.feature/branch@sha1:5394cb7f48332b2de7c17dd8b8384bbc84b7e738orsha1:5394cb7f48332b2de7c17dd8b8384bbc84b7e738).SplitRevision: allows for a legacy or RFC-0005 revision string to be split into a named-pointer and/or hash.ExtractNamedPointerFromRevision: allows for extracting a named pointer from a legacy or RFC-0005 revision string.ExtractHashFromRevision: allows for extracting a hash from a legacy or RFC-0005 revision string.