-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MS Adaptive Card payload to msteams
Provider
#920
Conversation
f6c1f15
to
573d0a6
Compare
1ec21e4
to
418bcfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @matheuscscp 🥇
418bcfd
to
c524772
Compare
msadaptivecard
Providermsteams
Provider
8173398
to
5563ce6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @matheuscscp 🏅
5563ce6
to
0259596
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good to me.
Left a few minor comments.
0259596
to
eff80ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Left a minor comment about the docs which can be addressed before merging.
Signed-off-by: Matheus Pimenta <[email protected]>
eff80ed
to
e0cf7a1
Compare
Fixes #878
The solution implemented in this PR for addressing the deprecation of the Office 365 Connector is checking the host of the address. If the suffix
.webhook.office.com
is present, the controller will keep the old behavior and send the existing payload format. Otherwise, a new payload format for Microsoft Adaptive Card will be sent, which is compatible with the new solution offered by Microsoft Teams: Incoming Webhook with Workflows.