Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MS Adaptive Card payload to msteams Provider #920

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

matheuscscp
Copy link
Collaborator

@matheuscscp matheuscscp commented Sep 6, 2024

Fixes #878

The solution implemented in this PR for addressing the deprecation of the Office 365 Connector is checking the host of the address. If the suffix .webhook.office.com is present, the controller will keep the old behavior and send the existing payload format. Otherwise, a new payload format for Microsoft Adaptive Card will be sent, which is compatible with the new solution offered by Microsoft Teams: Incoming Webhook with Workflows.

@matheuscscp matheuscscp force-pushed the ms-adaptive-card-provider branch 3 times, most recently from f6c1f15 to 573d0a6 Compare September 6, 2024 05:22
@stefanprodan stefanprodan added enhancement New feature or request area/alerting Alerting related issues and PRs labels Sep 6, 2024
@matheuscscp matheuscscp force-pushed the ms-adaptive-card-provider branch 2 times, most recently from 1ec21e4 to 418bcfd Compare September 7, 2024 03:36
@matheuscscp matheuscscp marked this pull request as ready for review September 7, 2024 03:36
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @matheuscscp 🥇

@matheuscscp matheuscscp changed the title Add msadaptivecard Provider Add MS Adaptive Card payload to msteams Provider Sep 10, 2024
@matheuscscp matheuscscp force-pushed the ms-adaptive-card-provider branch 2 times, most recently from 8173398 to 5563ce6 Compare September 10, 2024 17:50
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @matheuscscp 🏅

Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good to me.
Left a few minor comments.

docs/spec/v1beta3/providers.md Show resolved Hide resolved
internal/notifier/teams_fuzz_test.go Outdated Show resolved Hide resolved
internal/notifier/teams_test.go Outdated Show resolved Hide resolved
internal/notifier/teams_test.go Show resolved Hide resolved
internal/notifier/teams_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Left a minor comment about the docs which can be addressed before merging.

docs/spec/v1beta3/providers.md Outdated Show resolved Hide resolved
@matheuscscp matheuscscp merged commit 205cd17 into main Sep 12, 2024
6 checks passed
@matheuscscp matheuscscp deleted the ms-adaptive-card-provider branch September 12, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Alerting related issues and PRs enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Teams Incoming Webhook deprecation
3 participants