Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Gitea tests independent of 3rd-party service #558

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

makkes
Copy link
Member

@makkes makkes commented Jun 20, 2023

try.gitea.io, used before this change for testing the Gitea notifier, has been provisioned with a bug that broke the tests. Now, the tests are run against a mock HTTP server mimicking parts of Gitea's API so that the tests don't rely on that 3rd-pary service, anymore.

try.gitea.io, used before this change for testing the Gitea notifier,
has been provisioned with a bug that broke the tests. Now, the tests
are run against a mock HTTP server mimicking parts of Gitea's API so
that the tests don't rely on that 3rd-pary service, anymore.

Signed-off-by: Max Jonas Werner <[email protected]>
@makkes makkes requested a review from stefanprodan June 20, 2023 13:11
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @makkes 🏅

@stefanprodan stefanprodan added the area/ci CI related issues and pull requests label Jun 20, 2023
@stefanprodan stefanprodan merged commit 4343908 into main Jun 20, 2023
@stefanprodan stefanprodan deleted the fix-gitea-tests branch June 20, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants