Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code for parsing github payload #401

Merged
merged 3 commits into from
Aug 11, 2022
Merged

Remove code for parsing github payload #401

merged 3 commits into from
Aug 11, 2022

Conversation

somtochiama
Copy link
Member

@somtochiama somtochiama commented Aug 10, 2022

Closes #393

The go-github library doesn't parse the package event probably due to some inconsistencies in what Github sends and differences in their API documentation.
Since we don't use the Go struct returned, this code has now been removed.

This pull request also adds tests for the receiver handler.

Signed-off-by: Somtochi Onyekwere [email protected]

Signed-off-by: Somtochi Onyekwere <[email protected]>
Signed-off-by: Somtochi Onyekwere <[email protected]>
Signed-off-by: Somtochi Onyekwere <[email protected]>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @somtochiama 🏅

@stefanprodan stefanprodan merged commit b025972 into main Aug 11, 2022
@stefanprodan stefanprodan deleted the test-receiver branch August 11, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to parse package event from GitHub webhook
2 participants