Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use controller-runtime structured logging #156

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Use controller-runtime structured logging #156

merged 1 commit into from
Mar 15, 2021

Conversation

stefanprodan
Copy link
Member

Use controller-runtime structured logging, required by: fluxcd/flux2#1075

@stefanprodan stefanprodan added the enhancement New feature or request label Mar 15, 2021
hiddeco
hiddeco reviewed Mar 15, 2021
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be much easier to do something like logger := s.logger.WithValues(...values), and then use this logger for as long as the values apply?

@stefanprodan stefanprodan merged commit 2b98573 into main Mar 15, 2021
@stefanprodan stefanprodan deleted the logs branch March 15, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanprodan @hiddeco