Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOSSA scan enabled #32

Merged
merged 3 commits into from
Oct 8, 2020
Merged

FOSSA scan enabled #32

merged 3 commits into from
Oct 8, 2020

Conversation

idvoretskyi
Copy link
Member

Ref.: cncf/foundation#109

Signed-off-by: Ihor Dvoretskyi [email protected]

Signed-off-by: Ihor Dvoretskyi <[email protected]>
@idvoretskyi
Copy link
Member Author

cc @stefanprodan @dholbach

@stefanprodan
Copy link
Member

This repo is using main instead of master.

Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the API key be a secret, or is it not an issue?

@stefanprodan
Copy link
Member

The API key can't be a secret as this is intended to run on PRs. All CNCF projects uses it like this so I don't think it's an issue.

@squaremo squaremo merged commit 26138d3 into fluxcd:main Oct 8, 2020
@idvoretskyi idvoretskyi deleted the idvoretskyi-fossa branch October 8, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants