Move API v1alpha1 to v1alpha2 #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
v1alpha2
branch
2 times, most recently
from
707bf36 to
55ccd3e
Compare
The image automation part of the API has changed structure (see [1]), and had a version bump from `v1alpha1` to `v1alpha2`. Since the types here are also in `image.toolkit.fluxcd.io`, there will be less complication if they also get a version bump even though they aren't changing. [1] fluxcd/image-automation-controller#139 Signed-off-by: Michael Bridgen <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image automation part of the API has changed structure (see [1]),
and had a version bump from
v1alpha1tov1alpha2. Since the typeshere are also in
image.toolkit.fluxcd.io, there will be lesscomplication if they also get a version bump even though they aren't
changing.
For the automation types, leaving the old version
v1alpha1definitions in place leads to Kubernetes trying to upgrade objects and
dropping most fields (which have changed location), so they have been
removed. That would not happen with the types here, but for
consistency I am removing the old API version here too.
[1] fluxcd/image-automation-controller#139
NB This will not work for a live system at present; applying the CRD gives the error: