Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for force push #453

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Add support for force push #453

merged 1 commit into from
Nov 4, 2022

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Oct 31, 2022

Force push allows users to automatically update push branches that became stale. This feature only work for ImageUpdateAutomation objects which has a spec.PushBranch specified.

Fixes #450

Test image: ghcr.io/fluxcd/image-automation-controller:rc-842c6d78

@pjbgf pjbgf added the area/git Git related issues and pull requests label Oct 31, 2022
@pjbgf pjbgf added this to the GA milestone Oct 31, 2022
@pjbgf pjbgf force-pushed the shallow-force branch 3 times, most recently from 3879d98 to 72f6f96 Compare November 2, 2022 09:41
@pjbgf pjbgf changed the title Add suppot for shallow clone and force push Add support for force push Nov 2, 2022
Automations using a different push branch can now
enable force push to ensure that it gets refreshed
with the latest version of the branch used for the
clone operation.

Initially this was going to be added in combination
with Shallow clones for the `go-git` implementation.
However, force push is required for feature completeness
whilst Shallow clones are mostly an optimisation, and
will therefore be implemented at a later stage.

Signed-off-by: Paulo Gomes <[email protected]>
@pjbgf pjbgf marked this pull request as ready for review November 3, 2022 12:15
@pjbgf pjbgf requested a review from aryan9600 November 3, 2022 12:15
Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git Git related issues and pull requests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Git pushes to different branch are behind the base branch.
3 participants