Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil pointer deref during diff attempt #672

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Fix nil pointer deref during diff attempt #672

merged 1 commit into from
Apr 12, 2023

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Apr 12, 2023

Fixes #669
Fixes #671

@hiddeco hiddeco added the bug Something isn't working label Apr 12, 2023
stefanprodan
stefanprodan approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hiddeco 🥇

@hiddeco hiddeco force-pushed the fix-drift-nil-deref branch from 7a77c16 to 32b5d7e Compare April 12, 2023 09:41
@hiddeco hiddeco added the area/drift Drift detection/correction related issues and pull requests label Apr 12, 2023
@hiddeco hiddeco merged commit 96a17ef into main Apr 12, 2023
@hiddeco hiddeco deleted the fix-drift-nil-deref branch April 12, 2023 10:04
@darkowlzz darkowlzz mentioned this pull request Apr 24, 2023
Closed
1 task
@stefanprodan stefanprodan mentioned this pull request May 3, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/drift Drift detection/correction related issues and pull requests bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@hiddeco @stefanprodan