Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Helm to patched 3.8.0 #409

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Update Helm to patched 3.8.0 #409

merged 2 commits into from
Jan 28, 2022

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Jan 28, 2022

This updates Helm to a manually patched 3.8.0 release to include the
memory/goroutine leak fix: https://github.com/hiddeco/helm/commits/3.8.x

Potentially fixes #351

Multi-arch test image: docker.io/hiddeco/helm-controller:update-helm-a919ad5

@cbuto
Copy link
Contributor

cbuto commented Jan 28, 2022

✅ I tested this image under the same circumstances where we saw the helm-controller get OOMKilled before and the helm-controller was not OOMKilled (everything worked as expected 🎉 ). Since it was not OOMKilled, none of the HelmReleases got stuck with Helm upgrade failed: another operation (install/upgrade/rollback) is in progress.

@hiddeco hiddeco marked this pull request as ready for review January 28, 2022 17:50
@hiddeco hiddeco added area/ci CI related issues and pull requests area/helm Helm related issues and pull requests labels Jan 28, 2022
go.mod Show resolved Hide resolved
This updates Helm to a manually patched 3.8.0 release to include the
memory/goroutine leak fix:
https://github.com/hiddeco/helm/commits/3.8.x

Signed-off-by: Hidde Beydals <[email protected]>
Otherwise overwriting it with e.g. `--push` is not possible as the
combination with `--load` results in an error.

Signed-off-by: Hidde Beydals <[email protected]>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@hiddeco hiddeco merged commit f6bbf63 into main Jan 28, 2022
@hiddeco hiddeco deleted the update-helm branch January 28, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI related issues and pull requests area/helm Helm related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One failing HelmRelease seems to block all other releases from being installed/upgraded
3 participants