Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Generate MacOS universal static libraries #14

Merged
merged 4 commits into from
Feb 8, 2022
Merged

Generate MacOS universal static libraries #14

merged 4 commits into from
Feb 8, 2022

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Feb 7, 2022

This version generates universal static libraries for MacOs to support both x86_64 and arm64 for MacOS 10.15 or newer.

The different permutations of compiling settings let to a sightly more complex build script. This has been tested on Linux amd64, arm64 and Apple Silicon.

Paulo Gomes added 3 commits February 7, 2022 12:37
Signed-off-by: Paulo Gomes <[email protected]>
The changes on static.sh highlight the nuances of compiling for linux and mac, as well as cross compiling on the latter.

Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
In linux no-stdio resulted in some intermittent issues whilst
using libgit2.

Signed-off-by: Paulo Gomes <[email protected]>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @pjbgf 🏅

@stefanprodan stefanprodan merged commit 17b6b59 into fluxcd:libgit2-1.1.1 Feb 8, 2022
@pjbgf pjbgf deleted the testdarwin branch February 8, 2022 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants