Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HasTokenPermission to ensure token has requested permission #53

Merged
merged 6 commits into from
Sep 29, 2020

Conversation

yiannistri
Copy link
Collaborator

Resolves #52

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2020

Codecov Report

Merging #53 into master will increase coverage by 0.04%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   58.85%   58.89%   +0.04%     
==========================================
  Files          38       38              
  Lines        1694     1708      +14     
==========================================
+ Hits          997     1006       +9     
- Misses        571      574       +3     
- Partials      126      128       +2     
Impacted Files Coverage Δ
gitlab/client.go 75.00% <0.00%> (-3.95%) ⬇️
gitprovider/enums.go 100.00% <ø> (ø)
gitprovider/errors.go 0.00% <ø> (ø)
github/client.go 74.19% <61.53%> (-9.14%) ⬇️
github/githubclient.go 32.81% <0.00%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65d81e5...17b7f5a. Read the comment docs.

@yiannistri yiannistri force-pushed the validate-token-permissions branch from 4369e5f to d323caf Compare September 24, 2020 16:48
@yiannistri yiannistri marked this pull request as ready for review September 28, 2020 08:52
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please see the rename suggestion.

gitprovider/enums.go Outdated Show resolved Hide resolved
@yiannistri yiannistri force-pushed the validate-token-permissions branch from ab43531 to 5babcbf Compare September 29, 2020 13:53
@yiannistri yiannistri merged commit a444520 into master Sep 29, 2020
@yiannistri yiannistri deleted the validate-token-permissions branch September 29, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to check whether token permissions are sufficient for a given operation
3 participants